Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

Paul Mackerras
2007-05-09T10:51:46Z

Suparna Bhattacharya writes:

> > This looks like it will have the same problem on s390 as
> > sys_sync_file_range. Maybe the prototype should be:
> >
> > asmlinkage long sys_fallocate(loff_t offset, loff_t len, int fd, int mode)
>
> Yes, but the trouble is that there was a contrary viewpoint preferring that fd
> first be maintained as a convention like other syscalls (see the following
> posts)

Of course the interface used by an application program would have the
fd first. Glibc can do the translation.

Paul.