Re: [PATCH 2/7] fallocate() implementation in i386, x86_64 and powerpc

Stephen Rothwell
2007-07-11T02:35:47Z

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

On Wed, 11 Jul 2007 01:50:00 +0530 "Amit K. Arora" <aarora@linux.vnet.ibm.com> wrote:
>
> --- linux-2.6.22.orig/arch/x86_64/ia32/sys_ia32.c
> +++ linux-2.6.22/arch/x86_64/ia32/sys_ia32.c
> @@ -879,3 +879,11 @@ asmlinkage long sys32_fadvise64(int fd,
> return sys_fadvise64_64(fd, ((u64)offset_hi << 32) | offset_lo,
> len, advice);
> }
> +
> +asmlinkage long sys32_fallocate(int fd, int mode, unsigned offset_lo,
> + unsigned offset_hi, unsigned len_lo,
> + unsigned len_hi)

Please call this compat_sys_fallocate in line with the powerpc version -
it gives us a hint that maybe we should think about how to consolidate
them. I know other stuff in that file is called sys32_ ... but it is time
for a change :-)

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]