From: David Chinner <dgc@sgi.com>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>, xfs-dev <xfs-dev@sgi.com>
Subject: Re: REVIEW: fix xfs_bmap -vp confusion
Date: Wed, 11 Jul 2007 15:53:47 +1000 [thread overview]
Message-ID: <20070711055347.GP12413810@sgi.com> (raw)
In-Reply-To: <op.tu954us03jf8g2@pc-bnaujok.melbourne.sgi.com>
On Wed, Jul 11, 2007 at 01:18:20PM +1000, Barry Naujok wrote:
> If xfs_bmap -vp is run on a file without unwritten extents
> and the filesystem does not use sunit/swidth, the FLAGS
> column is not shown. This leads to some confusion.
>
> So, when -vp option is used, it will always print the
> FLAGS column.
I note that it only prints the legend if a flag is set. I guess
this is ok, but maybe it would be more consistent to always
print the legend? Or even to make the legend optional (which
would make dumping more than one file more compact)?
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-07-11 5:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 3:18 REVIEW: fix xfs_bmap -vp confusion Barry Naujok
2007-07-11 5:53 ` David Chinner [this message]
2007-07-11 6:04 ` Barry Naujok
2007-07-11 8:05 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070711055347.GP12413810@sgi.com \
--to=dgc@sgi.com \
--cc=bnaujok@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox