Re: REVIEW: fix xfs_bmap -vp confusion

[David Chinner <dgc@sgi.com>]

On Wed, Jul 11, 2007 at 04:04:05PM +1000, Barry Naujok wrote:
> On Wed, 11 Jul 2007 15:53:47 +1000, David Chinner <dgc@sgi.com> wrote:
> 
> >On Wed, Jul 11, 2007 at 01:18:20PM +1000, Barry Naujok wrote:
> >>If xfs_bmap -vp is run on a file without unwritten extents
> >>and the filesystem does not use sunit/swidth, the FLAGS
> >>column is not shown. This leads to some confusion.
> >>
> >>So, when -vp option is used, it will always print the
> >>FLAGS column.
> >
> >I note that it only prints the legend if a flag is set. I guess
> >this is ok, but maybe it would be more consistent to always
> >print the legend? Or even to make the legend optional (which
> >would make dumping more than one file more compact)?
> >
> >Cheers,
> >
> >Dave.
> 
> The legend* is only shown with an extra -v option and the FLAGS
> column displayed.

Ah, that'd be the > 1 check.

Looks good then....

> The updated man pages posted out yesterday documents this.

I haven't had time to read them yet.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group