From: David Chinner <dgc@sgi.com>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>, xfs-dev <xfs-dev@sgi.com>
Subject: Re: REVIEW: Make sure xfs_repair uses sector aligned I/O
Date: Fri, 13 Jul 2007 10:51:23 +1000 [thread overview]
Message-ID: <20070713005123.GH31489@sgi.com> (raw)
In-Reply-To: <op.tvdn7xhl3jf8g2@pc-bnaujok.melbourne.sgi.com>
On Fri, Jul 13, 2007 at 10:41:47AM +1000, Barry Naujok wrote:
> Two places it didn't:
> - reading the initial primary superblock
> - checking the log
>
> The log checking fix was basically porting the kernel
> xlog_bread/xlog_get_bp/xlog_align from the kernel and
> setting up the log_t structure properly in Phase 2.
>
> The initial primary superblock read is now done
> using the maximum supported sector size as once the
> block is read and translated to another location,
> it's discarded.
Seems OK from a quick look of the code. Were you able to
confirm that these are the only places we do non-sector sized
I/O?
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2007-07-13 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 0:41 REVIEW: Make sure xfs_repair uses sector aligned I/O Barry Naujok
2007-07-13 0:51 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070713005123.GH31489@sgi.com \
--to=dgc@sgi.com \
--cc=bnaujok@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox