From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] fix ASSERT and ASSERT_ALWAYS
Date: Mon, 16 Jul 2007 13:28:34 +1000 [thread overview]
Message-ID: <20070716032834.GK12413810@sgi.com> (raw)
In-Reply-To: <20070714160418.GA7768@lst.de>
On Sat, Jul 14, 2007 at 06:04:21PM +0200, Christoph Hellwig wrote:
> - remove the != 0 inside the unlikely in ASSERT_ALWAYS because sparse now
> complains about comparisms between pointers and 0
> - add a standalone ASSERT implementation because defining it to
> ASSERT_ALWAYS means the string is expanded before the #token passing
> stringification. This way we get the actual content of the
> assertatio in the assfail message and don't overflow sparse's
> strinification buffer leading to sparse error messages.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
OK.
Rather than replying to each patch, Christoph - I've taken the
whole set into my queue for 2.6.24. All the warnings and cleanups
look ok and should not be a problem, but I need to have a much
closer look at the bmbt_rec endian notation series before that
goes further.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2007-07-16 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 16:04 [PATCH] fix ASSERT and ASSERT_ALWAYS Christoph Hellwig
2007-07-14 16:38 ` Eric Sandeen
2007-07-16 3:28 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070716032834.GK12413810@sgi.com \
--to=dgc@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox