From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 7/7] - remove unused variable from locking macros
Date: Fri, 20 Jul 2007 08:30:23 +0100 [thread overview]
Message-ID: <20070720073023.GE29295@infradead.org> (raw)
In-Reply-To: <46A03631.7060604@sandeen.net>
On Thu, Jul 19, 2007 at 11:12:33PM -0500, Eric Sandeen wrote:
> The "s" in these locking macros used to be used like flags
> in spin_lock_irqsave; but in the xfs codebase today it's
> never used.
>
> gcc optimizes it away, but still, why keep it around?
If we change away from the IRIX compatible signatures we could just
kill the lock wrappers aswell..
next prev parent reply other threads:[~2007-07-20 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 4:12 [PATCH 7/7] - remove unused variable from locking macros Eric Sandeen
2007-07-20 7:30 ` Christoph Hellwig [this message]
2007-07-22 23:37 ` David Chinner
2007-07-23 13:55 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720073023.GE29295@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox