From: Christoph Hellwig <hch@lst.de>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] superblock endianess annotations
Date: Mon, 23 Jul 2007 10:45:51 +0200 [thread overview]
Message-ID: <20070723084551.GB1003@lst.de> (raw)
In-Reply-To: <20070723002432.GL31489@sgi.com>
On Mon, Jul 23, 2007 at 10:24:32AM +1000, David Chinner wrote:
> > +} xfs_dsb_t;
>
> Should this be packed so we don't reintroduce have the problem we currently
> do with 32-vs-64-bit alignment of the last field(s) in the structure?
There's no packing for the xfs_sb_t, so there's none in xfs_dsb_t
aswell. If you introduce packing for xfs_sb_t make sure to patch
xfs_dsb_t aswell.
Should we change names to xfs_sb_t for the ondisk one an xfs_icsb_t
here aswell? That would be a quite large change as there are a lot
more incore instances of the superblock than ondisk.
prev parent reply other threads:[~2007-07-23 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 16:33 [PATCH] superblock endianess annotations Christoph Hellwig
2007-07-23 0:24 ` David Chinner
2007-07-23 8:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723084551.GB1003@lst.de \
--to=hch@lst.de \
--cc=dgc@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox