Review: increase default filestreams timeout

Review: increase default filestreams timeout

[David Chinner]

The default is too low resulting in far too frequent workqueue
flushing and it's unlikely that it will work properly with buffered
I/O on such a low timeout. i.e. test 172 expects the timeout of 50
(default) expects buffered I/O to fail to lay the streams out
without interleaving.

Set the default timeout to 30s instead of 500ms.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

---
 fs/xfs/linux-2.6/xfs_globals.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_globals.c
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_globals.c	2007-07-09 16:06:23.000000000 +1000
+++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_globals.c	2007-07-17 09:06:46.595999067 +1000
@@ -49,7 +49,7 @@ xfs_param_t xfs_params = {
 	.inherit_nosym	= {	0,		0,		1	},
 	.rotorstep	= {	1,		1,		255	},
 	.inherit_nodfrg	= {	0,		1,		1	},
-	.fstrm_timer	= {	1,		50,		3600*100},
+	.fstrm_timer	= {	1,		30*100,		3600*100},
 };
 
 /*

Re: Review: increase default filestreams timeout

[Christoph Hellwig]

On Mon, Jul 23, 2007 at 12:06:30PM +1000, David Chinner wrote:
> The default is too low resulting in far too frequent workqueue
> flushing and it's unlikely that it will work properly with buffered
> I/O on such a low timeout. i.e. test 172 expects the timeout of 50
> (default) expects buffered I/O to fail to lay the streams out
> without interleaving.
> 
> Set the default timeout to 30s instead of 500ms.

The patch is obviously correct and I trust you on chosing the right timeout.