From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Tue, 31 Jul 2007 19:44:55 -0700 (PDT) Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l712hhbm001839 for ; Tue, 31 Jul 2007 19:43:45 -0700 Date: Wed, 1 Aug 2007 12:43:40 +1000 From: David Chinner Subject: Re: RFC: log record CRC validation Message-ID: <20070801024340.GS31489@sgi.com> References: <20070725092445.GT12413810@sgi.com> <46A7226D.8080906@sgi.com> <46A8DF7E.4090006@agami.com> <20070726233129.GM12413810@sgi.com> <46A94963.7000103@agami.com> <20070727065930.GT12413810@sgi.com> <46AFD88E.9070403@agami.com> <20070801022418.GR31489@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com List-Id: xfs To: Barry Naujok Cc: David Chinner , Michael Nishimoto , markgw@sgi.com, xfs-dev , xfs-oss On Wed, Aug 01, 2007 at 12:36:21PM +1000, Barry Naujok wrote: > On Wed, 01 Aug 2007 12:24:18 +1000, David Chinner wrote: > > >On Tue, Jul 31, 2007 at 05:49:18PM -0700, Michael Nishimoto wrote: > > > >>What are your plans for adding CRCs to other metadata objects? > > > >Other objects will require some on-disk format change, and that will > >require a feature bit to be set. > > > >Basically, we can add CRCs to individual inodes without a version bump > >as we have some empty space in the v2 inode core. That will make v2 > >inodes > >the default, but we already have a superblock bit for that and all > >versions > >of linux support v2 inodes so there is no issue there. This will require > >userspace tool changes, though, because tools like repair will revert v2 > >inodes back to v1 format if the are not using project id's or the link > >count > >fits into 16 bits..... > > No, repair does not revert v2 inodes back to v1. Currently, inodes > are created as v1 in the kernel and moved to v2 as required. Ah, yes, you're right - it's too easy to make flow mistakes in 1200 line functions.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group