public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: Mario Becroft <mb@gem.win.co.nz>
Cc: David Chinner <dgc@sgi.com>, linux-xfs@oss.sgi.com
Subject: Re: Proper method of snapshotting XFS with external log using LVM2
Date: Thu, 2 Aug 2007 00:09:44 +1000	[thread overview]
Message-ID: <20070801140944.GA31489@sgi.com> (raw)
In-Reply-To: <1185971009.13401.146.camel@server.ak.quickcircuit.co.nz>

On Thu, Aug 02, 2007 at 12:23:29AM +1200, Mario Becroft wrote:
> Hi David,
> 
> Thanks very much for your clear explanation of how to snapshot XFS
> filesystems with external log. It is good to know that I am doing it
> right.
> 
> I found that in the latest Linux kernel version 2.6.22.1, you cannot use
> the method I have been using, and which you confirmed is ok. The problem
> is that if you xfs_freeze the filesystem, then the LVM snapshot command
> hangs forever.

Ah, yes, I wondered if that still happened. The dm snapshot code is
a little naive - it just assumes that it is the only thing that can
freeze a device.

> (Back in kernel version 2.6.16 this did not happen.) I
> guess the snapshot command is also attempting to freeze the filesystem,
> or something, which doesn't work when it is already frozen.

It hangs on a lock that is held across the xfs_freeze -f ;
xfs_freeze -u sequence.

> I suppose
> how to fix this is a question for the linux-lvm mailing list.

IIRC from the last time this came, they'll tell you not to use
xfs_freeze.

As it is, the freeze_bdev() interface that both xfs_freeze and
dm-snapshot use is a complete pile of crud that we need to fix.
One of these days I'll get some time to fix it....

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

  reply	other threads:[~2007-08-01 14:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-29 19:32 Proper method of snapshotting XFS with external log using LVM2 Mario Becroft
2007-08-01 12:17 ` David Chinner
2007-08-01 12:23   ` Mario Becroft
2007-08-01 14:09     ` David Chinner [this message]
2007-08-01 15:02       ` Mario Becroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070801140944.GA31489@sgi.com \
    --to=dgc@sgi.com \
    --cc=linux-xfs@oss.sgi.com \
    --cc=mb@gem.win.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox