From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net, zippel@linux-m68k.org,
dhowells@redhat.com, linux-cifs-client@lists.samba.org,
codalist@TELEMANN.coda.cs.cmu.edu, joel.becker@oracle.com,
linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net,
cluster-devel@redhat.com,
user-mode-linux-user@lists.sourceforge.net,
mikulas@artax.karlin.mff.cuni.cz, wli@holomorphy.com,
jffs-dev@axis.com, jfs-discussion@lists.sourceforge.net,
ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org,
bfennema@falcon.csc.calpoly.edu, xfs@oss.sgi.com
Subject: Re: [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function
Date: Tue, 7 Aug 2007 21:51:49 +0100 [thread overview]
Message-ID: <20070807205145.GB30159@infradead.org> (raw)
In-Reply-To: <200708061354.l76Ds6sq002260@dantu.rdu.redhat.com>
> +void attr_kill_to_mode(struct inode *inode, struct iattr *attr)
This function badly needs a kerneldoc description. Also I can't say
I like the name a lot, but without a clearly better idea I should
probably not complain :)
We should at least add a generic_ prefix to indicate it's a generic
helper valid for most filesystem (and the kerneldoc comment can explain
the details)
next prev parent reply other threads:[~2007-08-07 21:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 13:54 [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function Jeff Layton
2007-08-06 17:43 ` [fuse-devel] " Miklos Szeredi
2007-08-06 18:13 ` Jeff Layton
2007-08-06 18:28 ` Miklos Szeredi
2007-08-06 19:04 ` Trond Myklebust
2007-08-06 19:37 ` Miklos Szeredi
2007-08-06 21:23 ` Trond Myklebust
2007-08-07 20:51 ` Christoph Hellwig [this message]
2007-08-07 22:20 ` Jeff Layton
-- strict thread matches above, loose matches on Subject: below --
2007-07-25 16:47 Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070807205145.GB30159@infradead.org \
--to=hch@infradead.org \
--cc=bfennema@falcon.csc.calpoly.edu \
--cc=cluster-devel@redhat.com \
--cc=codalist@TELEMANN.coda.cs.cmu.edu \
--cc=dhowells@redhat.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=jffs-dev@axis.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlayton@redhat.com \
--cc=joel.becker@oracle.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=ocfs2-devel@oss.oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=user-mode-linux-user@lists.sourceforge.net \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=wli@holomorphy.com \
--cc=xfs@oss.sgi.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox