From: David Chinner <dgc@sgi.com>
To: xfs-dev <xfs-dev@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH 4 of 4] Restore ihashsize mount option as deprecated
Date: Thu, 9 Aug 2007 21:45:48 +1000 [thread overview]
Message-ID: <20070809114548.GG12413810@sgi.com> (raw)
The ihashsize option should remain so that filesystems with
this set don't fail to mount. Ignore the mount option value
and issue a deprecation warning to syslog.
Update the ihashsize mount option documentation to indicate this
behaviour. Update the ikeep/noikeep mount option documentation
while we are there.
Signed-off-by: Dave Chinner <dgc@sgi.com>
---
Documentation/filesystems/xfs.txt | 14 ++++++--------
fs/xfs/xfs_vfsops.c | 3 +++
2 files changed, 9 insertions(+), 8 deletions(-)
Index: 2.6.x-xfs-new/fs/xfs/xfs_vfsops.c
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/xfs_vfsops.c 2007-08-09 13:03:53.000000000 +1000
+++ 2.6.x-xfs-new/fs/xfs/xfs_vfsops.c 2007-08-09 18:27:39.740905512 +1000
@@ -1883,6 +1883,9 @@ xfs_parseargs(
args->flags &= ~XFSMNT_ATTR2;
} else if (!strcmp(this_char, MNTOPT_FILESTREAM)) {
args->flags2 |= XFSMNT2_FILESTREAMS;
+ } else if (!strcmp(this_char, "ihashsize")) {
+ cmn_err(CE_WARN,
+ "XFS: ihashsize no longer used, option is deprecated.");
} else if (!strcmp(this_char, "osyncisdsync")) {
/* no-op, this is now the default */
cmn_err(CE_WARN,
Index: 2.6.x-xfs-new/Documentation/filesystems/xfs.txt
===================================================================
--- 2.6.x-xfs-new.orig/Documentation/filesystems/xfs.txt 2007-08-09 13:00:11.000000000 +1000
+++ 2.6.x-xfs-new/Documentation/filesystems/xfs.txt 2007-08-09 18:35:57.300771335 +1000
@@ -52,16 +52,14 @@ When mounting an XFS filesystem, the fol
and also gets the setgid bit set if it is a directory itself.
ihashsize=value
- Sets the number of hash buckets available for hashing the
- in-memory inodes of the specified mount point. If a value
- of zero is used, the value selected by the default algorithm
- will be displayed in /proc/mounts.
+ In memory inode hashes have been removed, so this option has
+ no function as of August 2007. Option is deprecated.
ikeep/noikeep
- When inode clusters are emptied of inodes, keep them around
- on the disk (ikeep) - this is the traditional XFS behaviour
- and is still the default for now. Using the noikeep option,
- inode clusters are returned to the free space pool.
+ When ikeep is specified, XFS does not delete empty inode clusters
+ and keeps them around on disk. ikeep is the traditional XFS
+ behaviour. When noikeep is specified, empty inode clusters
+ are returned to the free space pool. The default is noikeep.
inode64
Indicates that XFS is allowed to create inodes at any location
next reply other threads:[~2007-08-09 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 11:45 David Chinner [this message]
[not found] ` <46F4390A.5070407@sandeen.net>
2007-09-23 7:57 ` [PATCH 4 of 4] Restore ihashsize mount option as deprecated David Chinner
2007-09-23 10:00 ` Christoph Hellwig
[not found] ` <46F67BD3.8050706@sandeen.net>
2007-09-23 22:05 ` Mark Goodwin
2007-09-23 22:38 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070809114548.GG12413810@sgi.com \
--to=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox