From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] make xfs stats Kconfigurable
Date: Sun, 19 Aug 2007 20:10:10 +0100 [thread overview]
Message-ID: <20070819191010.GC2929@infradead.org> (raw)
In-Reply-To: <46C87C05.5040905@sandeen.net>
On Sun, Aug 19, 2007 at 12:21:09PM -0500, Eric Sandeen wrote:
> Oops, typo in Makefile (CONFIG_XFS_STAT vs _STATS).
>
> ----
>
>
> xfs stats are already optional based on CONFIG_PROC_FS, and there
> is already a (never-set) macro XFS_STATS_OFF which can turn them
> off. Making it a configurable option, if I turn them off I can
> get a little stack savings on x86, gcc 4.1:
Why would we want to disable the statistics?
> + config XFS_STATS
Everywhere else the config statement is not indented, so it probably
shouldn't be here either.
next prev parent reply other threads:[~2007-08-19 19:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-18 20:04 [PATCH] make xfs stats Kconfigurable Eric Sandeen
2007-08-19 17:21 ` [PATCH V2] " Eric Sandeen
2007-08-19 18:34 ` Eric Sandeen
2007-08-19 19:10 ` Christoph Hellwig [this message]
2007-08-19 19:13 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070819191010.GC2929@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox