From: David Chinner <dgc@sgi.com>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 5/17] move v_iocount from bhv_vnode to xfs_inode
Date: Fri, 24 Aug 2007 09:56:52 +1000 [thread overview]
Message-ID: <20070823235652.GZ72985246@sgi.com> (raw)
In-Reply-To: <20070823194749.GB8431@filer.fsl.cs.sunysb.edu>
On Thu, Aug 23, 2007 at 03:47:49PM -0400, Josef Sipek wrote:
> On Thu, Aug 23, 2007 at 09:38:18PM +0200, Christoph Hellwig wrote:
> > struct bhv_vnode is on it's way out, so move the I/O count to the XFS inode.
> >
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_aops.c
> > ===================================================================
> > --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_aops.c 2007-08-23 14:46:18.000000000 +0200
> > +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_aops.c 2007-08-23 14:51:38.000000000 +0200
> > @@ -140,9 +140,11 @@ xfs_destroy_ioend(
> > next = bh->b_private;
> > bh->b_end_io(bh, !ioend->io_error);
> > }
> > - if (unlikely(ioend->io_error))
> > - vn_ioerror(ioend->io_vnode, ioend->io_error, __FILE__,__LINE__);
> > - vn_iowake(ioend->io_vnode);
> > + if (unlikely(ioend->io_error)) {
> > + vn_ioerror(XFS_I(ioend->io_inode), ioend->io_error,
> > + __FILE__,__LINE__);
>
> Should it still be called vn_* if it takes an xfs inode? (And yes, I realize
> this is a patch in the middle of the series.)
Eventually, yes, but that's really only cosmetic at this point. I'm
more concerned with the functional and structural changes at this point
and not so much the cosmetics. There are much bigger cosmetic changes
in the pipeline as a result of this patchset, I think...
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2007-08-23 23:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 19:38 [PATCH 5/17] move v_iocount from bhv_vnode to xfs_inode Christoph Hellwig
2007-08-23 19:47 ` Josef Sipek
2007-08-23 23:56 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823235652.GZ72985246@sgi.com \
--to=dgc@sgi.com \
--cc=hch@lst.de \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox