From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/17] move v_trace from bhv_vnode to xfs_inode
Date: Fri, 24 Aug 2007 10:05:23 +1000 [thread overview]
Message-ID: <20070824000523.GA72985246@sgi.com> (raw)
In-Reply-To: <20070823193834.GG8050@lst.de>
On Thu, Aug 23, 2007 at 09:38:34PM +0200, Christoph Hellwig wrote:
> struct bhv_vnode is on it's way out, so move the trace buffer to the
> XFS inode. Note that this makes the tracing macros rather misnamed,
> but this kind of fallout will be fixed up incrementally later on.
....
> @@ -197,11 +192,11 @@ vn_hold(
> #ifdef XFS_VNODE_TRACE
>
> #define KTRACE_ENTER(vp, vk, s, line, ra) \
> - ktrace_enter( (vp)->v_trace, \
> + ktrace_enter( (ip)->i_trace, \
> /* 0 */ (void *)(__psint_t)(vk), \
> /* 1 */ (void *)(s), \
> /* 2 */ (void *)(__psint_t) line, \
> -/* 3 */ (void *)(__psint_t)(vn_count(vp)), \
> +/* 3 */ NULL, \
given that vn_count() returns the linux inode i_count, shouldn't
we put that here as well rather than killing it? It is sometimes
useful to see what is happening with the reference count in the
traces....
> +#ifdef XFS_VNODE_TRACE
> + ip->i_trace = ktrace_alloc(VNODE_TRACE_SIZE, KM_SLEEP);
> +#endif
At some point we need to change that define as well. More
cosmetic stuff, though.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-08-24 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 19:38 [PATCH 6/17] move v_trace from bhv_vnode to xfs_inode Christoph Hellwig
2007-08-24 0:05 ` David Chinner [this message]
2007-08-24 1:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070824000523.GA72985246@sgi.com \
--to=dgc@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox