Re: [PATCH 11/17] remove dependency of the quota module on behaviors.

[Christoph Hellwig <hch@lst.de>]

On Fri, Aug 24, 2007 at 10:26:12AM +1000, David Chinner wrote:
> > +static struct xfs_qmops xfs_qmcore_stub = {
> >  	.xfs_qminit		= (xfs_qminit_t) xfs_noquota_init,
> >  	.xfs_qmdone		= (xfs_qmdone_t) fs_noerr,
> >  	.xfs_qmmount		= (xfs_qmmount_t) fs_noerr,
> > @@ -124,4 +126,38 @@ xfs_qmops_t	xfs_qmcore_stub = {
> >  	.xfs_dqvoprename	= (xfs_dqvoprename_t) fs_noerr,
> >  	.xfs_dqvopchown		= xfs_dqvopchown_default,
> >  	.xfs_dqvopchownresv	= (xfs_dqvopchownresv_t) fs_noerr,
> > +	.xfs_dqstatvfs		= (xfs_dqstatvfs_t) fs_noval,
> > +	.xfs_dqsync		= (xfs_dqsync_t) fs_noerr,
> 
> That returns no error.
> 
> This is slightly non-obvious that if quotas are not enabled or loaded
> that this quota sync does not actually return an error. Perhaps a small
> addition to the comment above XFS_QM_DQSYNC() to explain this would
> help prevent future misunderstandings.

Sure, I'll add a comment.