From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] refactor xfs_mountfs for clarity & stack savings
Date: Tue, 28 Aug 2007 20:52:21 +0100 [thread overview]
Message-ID: <20070828195221.GA7237@infradead.org> (raw)
In-Reply-To: <46D37A82.2080608@sandeen.net>
Looks goo to me except for a tiny nitpick:
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net
> + if ((error = xfs_readsb(mp, mfsi_flags))) {
> + return error;
> + }
> + if ((error = xfs_update_alignment(mp, mfsi_flags, &update_flags)))
> + goto error1;
> + if ((error = xfs_check_sizes(mp, mfsi_flags)))
> + goto error1;
> if ((error = xfs_rtmount_init(mp))) {
Please make sure the assignment and conditional are on separate lines
for all of these once you're cleaning up this function. In the first
case there's also some braces to remove.
next prev parent reply other threads:[~2007-08-28 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-28 1:29 [PATCH] refactor xfs_mountfs for clarity & stack savings Eric Sandeen
2007-08-28 19:52 ` Christoph Hellwig [this message]
2007-08-28 20:24 ` Eric Sandeen
2007-08-28 20:55 ` [PATCH V2] " Eric Sandeen
2007-09-18 14:36 ` Christoph Hellwig
2007-09-29 9:48 ` Christoph Hellwig
2007-10-01 7:49 ` Donald Douwsma
2007-10-01 12:39 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070828195221.GA7237@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox