Re: [xfs-masters] [Bug 768] New: Move restrict_chown to mount-time option

[Josef Sipek <jsipek@fsl.cs.sunysb.edu>]

On Fri, Sep 07, 2007 at 09:04:27PM +0200, Christoph Hellwig wrote:
> On Thu, Sep 06, 2007 at 12:10:06PM -0400, Josef Sipek wrote:
> > > It's quite easily doable.  I don't have time for that right now, but if
> > > anyone wants to do it's just adding the option to the mount option
> > > parser and adding a flag to the mount structure.
> >  
> > Wouldn't making this a generic mount-option make sense? Or is it far too
> > low-level of a concept?
> 
> Basically it's a simple boolean flag that's checked in the inode
> allocator when we decide about the permission of the newly created
> inode.  Because of that the implementation will be inherently
> filesystem-specific.

Couldn't that be done just before the call to ->create as a mask on the
mode?

> We could still add a binary mount flag for it in common code, but my
> stance is to only add these when we actually need to check the flag in
> general code.

Or if the feature is so useful that all fs should support it. Is it useful?
If not, then I agree, not cluttering the VFS is a Good Thing.

Josef 'Jeff' Sipek.

-- 
Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are, by
definition, not smart enough to debug it.
		- Brian W. Kernighan