Re: [PATCH] remove dead SYNC_BDFLUSH case in xfs_sync_inodes

Eric Sandeen
2007-09-09T21:37:40Z

Bhagi rathi wrote:
> vfs_sync_worker calls with SYNC_BDFLUSH. xfssyncd can call this. I might be
> missing something
> if this is not used.
>
> Thanks,
> -Saradhi.

My eyes glazed over it too, but in xfs_syncsub as hch pointed out to me:

if (flags & (SYNC_ATTR|SYNC_DELWRI)) {
if (flags & SYNC_BDFLUSH)
xfs_finish_reclaim_all(mp, 1);
else
error = xfs_sync_inodes(mp, flags, bypassed);
}

so it won't be called with that flag.

-Eric