Re: [PATCH] remove dead SYNC_BDFLUSH case in xfs_sync_inodes

Bhagi rathi
2007-09-10T04:55:05Z

Ah, I see. It looks we don't use SYNC_BDFLUSH in xfs_sync_inodes. I believe
we don't
want to flush inodes from xfssync as inodes will be flushed by pdflush,
memory cleaner
threads. It looks like this code may be valid to other operating systems,
not for linux?

-Saradhi.

On 9/10/07, Eric Sandeen <sandeen@sandeen.net> wrote:
>
> Bhagi rathi wrote:
> > vfs_sync_worker calls with SYNC_BDFLUSH. xfssyncd can call this. I might
> be
> > missing something
> > if this is not used.
> >
> > Thanks,
> > -Saradhi.
>
>
> My eyes glazed over it too, but in xfs_syncsub as hch pointed out to me:
>
> if (flags & (SYNC_ATTR|SYNC_DELWRI)) {
> if (flags & SYNC_BDFLUSH)
> xfs_finish_reclaim_all(mp, 1);
> else
> error = xfs_sync_inodes(mp, flags, bypassed);
> }
>
> so it won't be called with that flag.
>
> -Eric
>

[[HTML alternate version deleted]]