From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
Donald Douwsma <donaldd@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH SERIES] untangle spinlock macros
Date: Wed, 12 Sep 2007 09:29:41 +0100 [thread overview]
Message-ID: <20070912082940.GA25373@infradead.org> (raw)
In-Reply-To: <46E78185.5040201@sgi.com>
On Wed, Sep 12, 2007 at 04:04:53PM +1000, Lachlan McIlroy wrote:
> These changes look good Eric.
>
> I'm in two minds about losing the spinlock_destroy() macros though. If
> Linux
> ever implements a spinlock teardown routine it would be nice to still have
> all
> the placeholders still there. Although I can't imagine it would do any more
> than assert that the lock is not currently held. If someone else wants to
> lose
> the macros then I'm not going to argue.
I'd say keep them for now. We don't need the spin.h header for them anyway,
as single macro can simply move to xfs_linux.h
next prev parent reply other threads:[~2007-09-12 8:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 5:05 [PATCH SERIES] untangle spinlock macros Eric Sandeen
2007-09-12 1:06 ` Lachlan McIlroy
2007-09-12 1:35 ` Eric Sandeen
2007-09-12 5:50 ` Lachlan McIlroy
2007-09-12 14:32 ` Eric Sandeen
2007-09-12 1:51 ` Donald Douwsma
2007-09-12 1:55 ` Eric Sandeen
2007-09-12 2:07 ` Eric Sandeen
2007-09-12 6:04 ` Lachlan McIlroy
2007-09-12 8:29 ` Christoph Hellwig [this message]
2007-09-13 3:02 ` Eric Sandeen
2007-09-21 21:04 ` Russell Cattelan
2007-09-13 3:04 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912082940.GA25373@infradead.org \
--to=hch@infradead.org \
--cc=donaldd@sgi.com \
--cc=lachlan@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox