Re: [PATCH SERIES] untangle spinlock macros

Christoph Hellwig
2007-09-12T08:57:01Z

On Wed, Sep 12, 2007 at 04:04:53PM +1000, Lachlan McIlroy wrote:
> These changes look good Eric.
>
> I'm in two minds about losing the spinlock_destroy() macros though. If
> Linux
> ever implements a spinlock teardown routine it would be nice to still have
> all
> the placeholders still there. Although I can't imagine it would do any more
> than assert that the lock is not currently held. If someone else wants to
> lose
> the macros then I'm not going to argue.

I'd say keep them for now. We don't need the spin.h header for them anyway,
as single macro can simply move to xfs_linux.h