From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Cc: sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com
Subject: Re: TAKE 968767 - Ensure file size updates have been completed before writing inode to disk.
Date: Thu, 13 Sep 2007 12:20:46 +0100 [thread overview]
Message-ID: <20070913112046.GA25515@infradead.org> (raw)
In-Reply-To: <200709130330.l8D3UGu9004196@redback.melbourne.sgi.com>
This has never been out for review, has it?
On Thu, Sep 13, 2007 at 01:30:16PM +1000, Lachlan McIlroy wrote:
> fs/xfs/xfs_vnodeops.c - 1.720 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/linux-2.4-xfs/> xfs_vnodeops.c.diff?r1=text&tr1=1.720&r2=text&tr2=1.719&f=h
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vnodeops.c.diff?r1=text&tr1=1.720&r2=text&tr2=1.719&f=h
> - Ensure file size updates have been completed before writing inode to disk.
I think you want to at least add a comment above the filemap_fdatawait
call why we have it that early compared to where the generic code calls
it (again). But hopefully I'll push changes to the core code soon
to move the filemap_datawrite/wait into fs domain completely.
I also don't like idioms like vn_to_inode(XFS_ITOV(ip)) at all. Just
doing a direct ip->i_vnode deference sounds perfectly fine.
Why is removing the ipincount check in xfs_inode_flush okay? Trying
to flush pinned inodes doesn't seem that much of a good idea.
next prev parent reply other threads:[~2007-09-13 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 3:30 TAKE 968767 - Ensure file size updates have been completed before writing inode to disk Lachlan McIlroy
2007-09-13 11:20 ` Christoph Hellwig [this message]
2007-09-14 0:05 ` David Chinner
2007-09-14 14:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070913112046.GA25515@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@redback.melbourne.sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox