From: Christoph Hellwig <hch@infradead.org>
To: Bhagi rathi <jahnu77@gmail.com>
Cc: "donaldd@sgi.com" <donaldd@sgi.com>,
xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com
Subject: Re: TAKE 970240 - kill BMAPI_DEVICE
Date: Thu, 13 Sep 2007 21:30:55 +0100 [thread overview]
Message-ID: <20070913203055.GA14895@infradead.org> (raw)
In-Reply-To: <cc7060690709131223o7bb4f75sd6a42e30a6a078c3@mail.gmail.com>
On Fri, Sep 14, 2007 at 12:53:20AM +0530, Bhagi rathi wrote:
> Can one of you let me know the process of submitting changes?
Just send a unified diff (using diff -u) to the list.
>
> Problem: Real time flag set on a regular file can race with directio which
> can lead to
> incorrect real time device for iomap in xfs_vm_direct_IO. This
> can happen
> only on the first I/O to the file as we don't set real time
> flag if any of
> the extents or delayed blocks present.
>
> Fix:
>
> xfs_setattr() {
> ...
> if (!(mask & XFS_AT_SIZE)) {
> if (need_io_lock && vap->va_xflags & XFS_XFLAG_REALTIME)
> lock_flags |= XFS_IOLOCK_EXCL;
> .....
> }
I have a patch queued up aswell, although it's after a reorganization of
the code to not clutter xfs_setattr even more. If you want to send out
the fix now please go ahead.
prev parent reply other threads:[~2007-09-13 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 4:34 TAKE 970240 - kill BMAPI_DEVICE donaldd
2007-09-13 19:23 ` Bhagi rathi
2007-09-13 20:30 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070913203055.GA14895@infradead.org \
--to=hch@infradead.org \
--cc=donaldd@sgi.com \
--cc=jahnu77@gmail.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox