* [PATCH] kill XFS_INOBT_IS_FREE_DISK
@ 2007-09-19 16:12 Christoph Hellwig
2007-09-19 18:15 ` Eric Sandeen
2007-09-29 9:45 ` Christoph Hellwig
0 siblings, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2007-09-19 16:12 UTC (permalink / raw)
To: xfs
This macro is unused an all other acros in this family operate on native
types, so we most likely won't grow a user either.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6.23-rc6/fs/xfs/xfs_ialloc_btree.h
===================================================================
--- linux-2.6.23-rc6.orig/fs/xfs/xfs_ialloc_btree.h 2007-09-18 16:27:08.000000000 +0200
+++ linux-2.6.23-rc6/fs/xfs/xfs_ialloc_btree.h 2007-09-18 16:27:18.000000000 +0200
@@ -81,8 +81,6 @@ typedef struct xfs_btree_sblock xfs_inob
#define XFS_INOBT_MASK(i) ((xfs_inofree_t)1 << (i))
#define XFS_INOBT_IS_FREE(rp,i) \
(((rp)->ir_free & XFS_INOBT_MASK(i)) != 0)
-#define XFS_INOBT_IS_FREE_DISK(rp,i) \
- ((be64_to_cpu((rp)->ir_free) & XFS_INOBT_MASK(i)) != 0)
#define XFS_INOBT_SET_FREE(rp,i) ((rp)->ir_free |= XFS_INOBT_MASK(i))
#define XFS_INOBT_CLR_FREE(rp,i) ((rp)->ir_free &= ~XFS_INOBT_MASK(i))
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kill XFS_INOBT_IS_FREE_DISK
2007-09-19 16:12 [PATCH] kill XFS_INOBT_IS_FREE_DISK Christoph Hellwig
@ 2007-09-19 18:15 ` Eric Sandeen
2007-09-19 20:22 ` Christoph Hellwig
2007-09-29 9:45 ` Christoph Hellwig
1 sibling, 1 reply; 6+ messages in thread
From: Eric Sandeen @ 2007-09-19 18:15 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> This macro is unused an all other acros in this family operate on native
> types, so we most likely won't grow a user either.
Looks good to me... FWIW, here are the currently-unused macros in xfs
cvs, if I'm massaging it right:
_ACL_ACCESS_EXISTS
_ACL_GET_ACCESS
ATTR_DONTFOLLOW
ATTR_TRUST
BMBT_USE_64
CE_CONT
current_clear_flags_nested
FSYNC_INVAL
FSYNC_NOWAIT
HAVE_DM_EVENTTYPE_T
HAVE_DM_RIGHT_T
HAVE_SPLICE
MODEMASK
NDPP
nested_spinlock
nested_spinunlock
SGI_ACL_DEFAULT_SIZE
SV_KEYED
SV_LIFO
SV_PRIO
sv_timedwait
sv_timedwait_sig
sv_wait_sig
TRACE0
TRACE1
TRACE3
VN_ISBLK
VN_ISCHR
VN_ISLNK
VREAD
VSUID
VSVTX
VWRITE
XB_GET_OWNER
XFS_AT_ALL
XFS_AT_SIZE_NOPERM
XFS_AT_TIMES
xfs_buf_ctob
XFS_BUF_ISORDERED
XFS_BUF_ISWRITE
XFS_BUF_OFFSET
XFS_BUF_SET_OFFSET
XFS_BUF_SET_SIZE
XFS_BUF_UNBUSY
XFS_BUF_VSEMA
XFS_DA_MAXHASH
XFS_DFORK_ASIZE_HOST
XFS_DFORK_DSIZE_HOST
XFS_ERRLEVEL_OFF
XFS_ERRTAG_DIOWRITE_IOERR
XFS_ERRTAG_MAX
XFS_ERRTAG_NOERROR
XFS_ERRTAG_STRATCMPL_IOERR
XFS_ERRTAG_STRATREAD_IOERR
XFS_EXTENT_TOKEN_WR
XFS_IO_DCXVN
XFS_IOMAP_WRITE_UNWRITTEN
XFS_IS_PQUOTA_RUNNING
XFS_LID_PINNED
XFS_MAX_LOG_BLOCKS
XFS_MAX_LOG_BYTES
xfs_probe_dmapi
xfs_probe_ioops
xfs_probe_quota
XFS_QMOPT_DOLOG
XFS_RANDOM_DIOWRITE_IOERR
XFS_RANDOM_STRATCMPL_IOERR
XFS_RANDOM_STRATREAD_IOERR
XFS_SBF_NOFLAGS
XFS_SB_VERSION2_REALFBITS
XFS_SB_VERSION2_RESERVED1BIT
XFS_SB_VERSION2_RESERVED4BIT
XFS_SB_VERSION_ADDDALIGN
XFS_SB_VERSION_ADDEXTFLGBIT
XFS_SB_VERSION_ADDSHARED
XFS_SB_VERSION_SUBEXTFLGBIT
XFS_SB_VERSION_SUBSHARED
XFS_SIZE_TOKEN_WR
XFS_SX_VERSION
xlog_exit
XLOG_FMT_IRIX_BE
XLOG_MIN_RECORD_BSHIFT
XLOG_RHASH_BITS
XLOG_SET
XLOG_STATE_NOTUSED
-Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kill XFS_INOBT_IS_FREE_DISK
2007-09-19 18:15 ` Eric Sandeen
@ 2007-09-19 20:22 ` Christoph Hellwig
2007-09-19 20:29 ` Eric Sandeen
2007-09-19 20:44 ` nscott
0 siblings, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2007-09-19 20:22 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Christoph Hellwig, xfs
On Wed, Sep 19, 2007 at 01:15:46PM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > This macro is unused an all other acros in this family operate on native
> > types, so we most likely won't grow a user either.
>
> Looks good to me... FWIW, here are the currently-unused macros in xfs
> cvs, if I'm massaging it right:
>
> _ACL_ACCESS_EXISTS
> _ACL_GET_ACCESS
> SGI_ACL_DEFAULT_SIZE
will go away with conversion to generic posix acl code.
> ATTR_DONTFOLLOW
> ATTR_TRUST
might go away with conversion to generic xattr code.
> BMBT_USE_64
I have a patch for this one.
> CE_CONT
> current_clear_flags_nested
> FSYNC_INVAL
> FSYNC_NOWAIT
We should probably kill these.
> HAVE_DM_EVENTTYPE_T
> HAVE_DM_RIGHT_T
no idea for these.
> HAVE_SPLICE
Backward compat?
> MODEMASK
> NDPP
kill?
> nested_spinlock
> nested_spinunlock
don't your patches kill these?
> SV_KEYED
> SV_LIFO
> SV_PRIO
> sv_timedwait
> sv_timedwait_sig
> sv_wait_sig
should probably go.
> TRACE0
> TRACE1
> TRACE3
kill?
> VN_ISBLK
> VN_ISCHR
> VN_ISLNK
> VREAD
> VSUID
> VSVTX
> VWRITE
I have a patch to kill all this gunk.
> XFS_AT_ALL
> XFS_AT_SIZE_NOPERM
> XFS_AT_TIMES
I have some patches patch to kill XFS_AT_*
> XFS_DFORK_ASIZE_HOST
> XFS_DFORK_DSIZE_HOST
I have some patches to rework XFS_{C,D,I}FORK*
> XB_GET_OWNER
> xfs_buf_ctob
> XFS_BUF_ISORDERED
> XFS_BUF_ISWRITE
> XFS_BUF_OFFSET
> XFS_BUF_SET_OFFSET
> XFS_BUF_SET_SIZE
> XFS_BUF_UNBUSY
> XFS_BUF_VSEMA
not sure what to do with all the buf stuff.
> XFS_IO_DCXVN
> XFS_IOMAP_WRITE_UNWRITTEN
should be gone with the patches I sent to the list.
> xfs_probe_dmapi
> xfs_probe_ioops
> xfs_probe_quota
these are gone in a patch that I sent to the list already.
> XFS_SBF_NOFLAGS
> XFS_SB_VERSION2_REALFBITS
> XFS_SB_VERSION2_RESERVED1BIT
> XFS_SB_VERSION2_RESERVED4BIT
> XFS_SB_VERSION_ADDDALIGN
> XFS_SB_VERSION_ADDEXTFLGBIT
> XFS_SB_VERSION_ADDSHARED
> XFS_SB_VERSION_SUBEXTFLGBIT
> XFS_SB_VERSION_SUBSHARED
I suspect there are kind expected to be unused.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kill XFS_INOBT_IS_FREE_DISK
2007-09-19 20:22 ` Christoph Hellwig
@ 2007-09-19 20:29 ` Eric Sandeen
2007-09-19 20:44 ` nscott
1 sibling, 0 replies; 6+ messages in thread
From: Eric Sandeen @ 2007-09-19 20:29 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
>
>> HAVE_SPLICE
>
>
> Backward compat?
ah, yeah, it's for 2.4:
0 xfs/linux-2.6/xfs_linux.h <global> 104 #define HAVE_SPLICE
1 fs/xfs/xfs_vnodeops.c <global> 4718 #ifdef HAVE_SPLICE
can probably go soon eh. HAVE_PERCPU_SB can too (not sure why it's not
in my list) There may be others that are just for 2.4.
>
>> nested_spinlock
>> nested_spinunlock
>
> don't your patches kill these?
yeah, I just checked pristine cvs.
-Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kill XFS_INOBT_IS_FREE_DISK
2007-09-19 20:22 ` Christoph Hellwig
2007-09-19 20:29 ` Eric Sandeen
@ 2007-09-19 20:44 ` nscott
1 sibling, 0 replies; 6+ messages in thread
From: nscott @ 2007-09-19 20:44 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Eric Sandeen, xfs
> On Wed, Sep 19, 2007 at 01:15:46PM -0500, Eric Sandeen wrote:
>> Christoph Hellwig wrote:
>> ...
>> XFS_SBF_NOFLAGS
>> XFS_SB_VERSION2_REALFBITS
>> XFS_SB_VERSION2_RESERVED1BIT
>> XFS_SB_VERSION2_RESERVED4BIT
>> XFS_SB_VERSION_ADDDALIGN
>> XFS_SB_VERSION_ADDEXTFLGBIT
>> XFS_SB_VERSION_ADDSHARED
>> XFS_SB_VERSION_SUBEXTFLGBIT
>> XFS_SB_VERSION_SUBSHARED
>
> I suspect there are kind expected to be unused.
>
They're used in userspace IIRC. (Well, some - probably not the RESERVED
ones)
cheers.
--
Nathan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kill XFS_INOBT_IS_FREE_DISK
2007-09-19 16:12 [PATCH] kill XFS_INOBT_IS_FREE_DISK Christoph Hellwig
2007-09-19 18:15 ` Eric Sandeen
@ 2007-09-29 9:45 ` Christoph Hellwig
1 sibling, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2007-09-29 9:45 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Wed, Sep 19, 2007 at 06:12:03PM +0200, Christoph Hellwig wrote:
> This macro is unused an all other acros in this family operate on native
> types, so we most likely won't grow a user either.
Could anyone put this trivial remove one line patch in?
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6.23-rc6/fs/xfs/xfs_ialloc_btree.h
> ===================================================================
> --- linux-2.6.23-rc6.orig/fs/xfs/xfs_ialloc_btree.h 2007-09-18 16:27:08.000000000 +0200
> +++ linux-2.6.23-rc6/fs/xfs/xfs_ialloc_btree.h 2007-09-18 16:27:18.000000000 +0200
> @@ -81,8 +81,6 @@ typedef struct xfs_btree_sblock xfs_inob
> #define XFS_INOBT_MASK(i) ((xfs_inofree_t)1 << (i))
> #define XFS_INOBT_IS_FREE(rp,i) \
> (((rp)->ir_free & XFS_INOBT_MASK(i)) != 0)
> -#define XFS_INOBT_IS_FREE_DISK(rp,i) \
> - ((be64_to_cpu((rp)->ir_free) & XFS_INOBT_MASK(i)) != 0)
> #define XFS_INOBT_SET_FREE(rp,i) ((rp)->ir_free |= XFS_INOBT_MASK(i))
> #define XFS_INOBT_CLR_FREE(rp,i) ((rp)->ir_free &= ~XFS_INOBT_MASK(i))
>
>
>
---end quoted text---
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-09-29 10:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-19 16:12 [PATCH] kill XFS_INOBT_IS_FREE_DISK Christoph Hellwig
2007-09-19 18:15 ` Eric Sandeen
2007-09-19 20:22 ` Christoph Hellwig
2007-09-19 20:29 ` Eric Sandeen
2007-09-19 20:44 ` nscott
2007-09-29 9:45 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox