public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* Review: Fix xfsidbg.c compiler warnings on x86_64
@ 2007-09-24  9:17 Donald Douwsma
  2007-09-24 18:03 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Donald Douwsma @ 2007-09-24  9:17 UTC (permalink / raw)
  To: xfs-oss

Fix compile warnings for xfsidbg.c as seen on x86_64.

--- 2.6.x-xfs.orig/fs/xfs/xfsidbg.c
+++ 2.6.x-xfs/fs/xfs/xfsidbg.c
@@ -1798,10 +1798,10 @@ xfs_itrace_pr_entry(ktrace_entry_t *ktep
  	if ((__psint_t)ktep->val[0] == 0)
  		return 0;

-	if (kdbnearsym((unsigned int)ktep->val[8], &symtab)) {
+	if (kdbnearsym((unsigned long)ktep->val[8], &symtab)) {
  		unsigned long offval;

-		offval = (unsigned int)ktep->val[8] - symtab.sym_start;
+		offval = (unsigned long)ktep->val[8] - symtab.sym_start;

  		if (offval)
  			sprintf(funcname, "%s+0x%lx", symtab.sym_name, offval);
@@ -1871,13 +1871,13 @@ xfs_itrace_pr_entry(ktrace_entry_t *ktep

  	kdb_printf("\n");

-	kdb_printf("  cpu = %ld pid = %d ",
-			(long)ktep->val[6], (pid_t)ktep->val[7]);
+	kdb_printf("  cpu = %ld pid = %ld ",
+			(long)ktep->val[6], (long)ktep->val[7]);

-	if (kdbnearsym((unsigned int)ktep->val[4], &symtab)) {
+	if (kdbnearsym((unsigned long)ktep->val[4], &symtab)) {
  		unsigned long offval;

-		offval = (unsigned int)ktep->val[4] - symtab.sym_start;
+		offval = (unsigned long)ktep->val[4] - symtab.sym_start;

  		if (offval)
  			kdb_printf("  ra = %s+0x%lx", symtab.sym_name, offval);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Review: Fix xfsidbg.c compiler warnings on x86_64
  2007-09-24  9:17 Review: Fix xfsidbg.c compiler warnings on x86_64 Donald Douwsma
@ 2007-09-24 18:03 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2007-09-24 18:03 UTC (permalink / raw)
  To: Donald Douwsma; +Cc: xfs-oss

On Mon, Sep 24, 2007 at 07:17:17PM +1000, Donald Douwsma wrote:
> Fix compile warnings for xfsidbg.c as seen on x86_64.

Looks good.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-09-24 18:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-24  9:17 Review: Fix xfsidbg.c compiler warnings on x86_64 Donald Douwsma
2007-09-24 18:03 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox