From: Chris Wedgwood <cw@f00f.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] lose xfs_hex_dump in favor of print_hex_dump
Date: Mon, 24 Sep 2007 17:32:32 -0700 [thread overview]
Message-ID: <20070925003232.GA26663@puku.stupidest.org> (raw)
In-Reply-To: <46F85240.1060206@sandeen.net>
On Mon, Sep 24, 2007 at 07:11:44PM -0500, Eric Sandeen wrote:
> +extern void xfs_hex_dump(void *p, int length);
> +
> +void
> +xfs_hex_dump(void *p, int length)
> +{
> + print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_OFFSET, 16, 1, p, length, 1);
> +}
Is this symbol exported/needed? If not then why not make it a #define
or an inline in the header where you have the prototype?
next prev parent reply other threads:[~2007-09-25 0:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 0:11 [PATCH] lose xfs_hex_dump in favor of print_hex_dump Eric Sandeen
2007-09-25 0:32 ` Chris Wedgwood [this message]
2007-09-25 1:31 ` Eric Sandeen
2007-09-25 8:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925003232.GA26663@puku.stupidest.org \
--to=cw@f00f.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox