From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Chris Wedgwood <cw@f00f.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] lose xfs_hex_dump in favor of print_hex_dump
Date: Tue, 25 Sep 2007 09:28:56 +0100 [thread overview]
Message-ID: <20070925082856.GA9786@infradead.org> (raw)
In-Reply-To: <46F86501.7070605@sandeen.net>
On Mon, Sep 24, 2007 at 08:31:45PM -0500, Eric Sandeen wrote:
> >> +void
> >> +xfs_hex_dump(void *p, int length)
> >> +{
> >> + print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_OFFSET, 16, 1, p, length, 1);
> >> +}
> >
> > Is this symbol exported/needed? If not then why not make it a #define
> > or an inline in the header where you have the prototype?
>
> Yeah, I suppose that might be better.... I just followed the lead of
> xfs_cmn_err etc.
>
> The only reason I left a wrapper was for cattelan's BSD exploits
> (er, adventures) ;-) I could imagine it getting called from other places,
> but for now it only has one caller, xfs_corruption_error (so really, even
> the length argument is never anything other than 16...)
No point in making anything in an absolute slowpath inline or a macro.
I think the patch is fine as-is.
prev parent reply other threads:[~2007-09-25 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 0:11 [PATCH] lose xfs_hex_dump in favor of print_hex_dump Eric Sandeen
2007-09-25 0:32 ` Chris Wedgwood
2007-09-25 1:31 ` Eric Sandeen
2007-09-25 8:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925082856.GA9786@infradead.org \
--to=hch@infradead.org \
--cc=cw@f00f.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox