public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] kill XFS_INOBT_IS_FREE_DISK
Date: Sat, 29 Sep 2007 10:45:52 +0100	[thread overview]
Message-ID: <20070929094552.GC29241@infradead.org> (raw)
In-Reply-To: <20070919161202.GA18130@lst.de>

On Wed, Sep 19, 2007 at 06:12:03PM +0200, Christoph Hellwig wrote:
> This macro is unused an all other acros in this family operate on native
> types, so we most likely won't grow a user either.

Could anyone put this trivial remove one line patch in?

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6.23-rc6/fs/xfs/xfs_ialloc_btree.h
> ===================================================================
> --- linux-2.6.23-rc6.orig/fs/xfs/xfs_ialloc_btree.h	2007-09-18 16:27:08.000000000 +0200
> +++ linux-2.6.23-rc6/fs/xfs/xfs_ialloc_btree.h	2007-09-18 16:27:18.000000000 +0200
> @@ -81,8 +81,6 @@ typedef	struct xfs_btree_sblock xfs_inob
>  #define	XFS_INOBT_MASK(i)		((xfs_inofree_t)1 << (i))
>  #define	XFS_INOBT_IS_FREE(rp,i)		\
>  		(((rp)->ir_free & XFS_INOBT_MASK(i)) != 0)
> -#define	XFS_INOBT_IS_FREE_DISK(rp,i)	\
> -		((be64_to_cpu((rp)->ir_free) & XFS_INOBT_MASK(i)) != 0)
>  #define	XFS_INOBT_SET_FREE(rp,i)	((rp)->ir_free |= XFS_INOBT_MASK(i))
>  #define	XFS_INOBT_CLR_FREE(rp,i)	((rp)->ir_free &= ~XFS_INOBT_MASK(i))
>  
> 
> 
---end quoted text---

      parent reply	other threads:[~2007-09-29 10:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 16:12 [PATCH] kill XFS_INOBT_IS_FREE_DISK Christoph Hellwig
2007-09-19 18:15 ` Eric Sandeen
2007-09-19 20:22   ` Christoph Hellwig
2007-09-19 20:29     ` Eric Sandeen
2007-09-19 20:44     ` nscott
2007-09-29  9:45 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070929094552.GC29241@infradead.org \
    --to=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox