From: lachlan@sgi.com (Lachlan McIlroy)
To: sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com
Subject: TAKE 971186 - clean up some xfs_log_priv.h macros
Date: Tue, 2 Oct 2007 14:50:26 +1000 (EST) [thread overview]
Message-ID: <20071002045026.A77AF58C38F1@chook.melbourne.sgi.com> (raw)
clean up some xfs_log_priv.h macros
- the various assign lsn macros are replaced by a single inline,
xlog_assign_lsn, which is equivalent to ASSIGN_ANY_LSN_HOST except
for a more sane calling convention. ASSIGN_LSN_DISK is replaced
by xlog_assign_lsn and a manual bytespap, and ASSIGN_LSN by the same,
except we pass the cycle and block arguments explicitly instead of a
log paramter. The latter two variants only had 2, respectively one
user anyway.
- the GET_CYCLE is replaced by a xlog_get_cycle inline with exactly the
same calling conventions.
- GET_CLIENT_ID is replaced by xlog_get_client_id which leaves away
the unused arch argument. Instead of conditional defintions
depending on host endianess we now do an unconditional swap and shift
then, which generates equal code.
- the unused XLOG_SET macro is removed.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Date: Tue Oct 2 14:34:49 AEST 2007
Workarea: redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-oss
Inspected by: Christoph Hellwig <hch@lst.de>
Author: lachlan
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
Modid: xfs-linux-melb:xfs-kern:29819a
fs/xfs/xfs_log.c - 1.340 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_log.c.diff?r1=text&tr1=1.340&r2=text&tr2=1.339&f=h
fs/xfs/xfs_log_priv.h - 1.123 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_log_priv.h.diff?r1=text&tr1=1.123&r2=text&tr2=1.122&f=h
fs/xfs/xfs_log_recover.c - 1.327 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_log_recover.c.diff?r1=text&tr1=1.327&r2=text&tr2=1.326&f=h
- clean up some xfs_log_priv.h macros
next reply other threads:[~2007-10-02 4:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 4:50 Lachlan McIlroy [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-02 4:51 TAKE 971186 - clean up some xfs_log_priv.h macros Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071002045026.A77AF58C38F1@chook.melbourne.sgi.com \
--to=lachlan@sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox