From: David Chinner <dgc@sgi.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: Timothy Shimmin <tes@sgi.com>, Eric Sandeen <sandeen@sandeen.net>,
xfs@oss.sgi.com
Subject: Re: [GIT PULL] XFS update for 2.6.23 - revert a commit
Date: Tue, 2 Oct 2007 19:36:29 +1000 [thread overview]
Message-ID: <20071002093629.GG995458@sgi.com> (raw)
In-Reply-To: <4701ED51.8050706@sgi.com>
On Tue, Oct 02, 2007 at 05:03:45PM +1000, Lachlan McIlroy wrote:
> Yeah that about sums it up. In an attempt to prevent log replay of inodes
> in cases when we shouldn't replay we also prevented log replay of inodes in
> cases when we should replay. We end up with directories that refer to
> inodes
> that were not replayed and we read existing data off disk. That existing
> data is usually previous instances of inodes. We had cases of regular files
> turning into directories and inode version mismatches.
The issue that started tripping this was stale inodes from a
previous filesystem being detected as valid clusters of inodes.
Hence inodes magically changed from what they were supposed to
be and that caused all sorts of problems.
FWIW, in a past life XFS was supposed to store the uuid of the
filesystem in it's inodes to prevent exactly this sort of confusion,
but that was considered expendable and disappeared in version 2
inodes when XFS grew 32bit link counts and project ID's. The padding
is still there waiting to be used.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-10-02 9:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 7:23 [GIT PULL] XFS update for 2.6.23 - revert a commit Tim Shimmin
2007-10-01 12:55 ` Eric Sandeen
2007-10-01 13:05 ` Eric Sandeen
2007-10-01 13:12 ` Eric Sandeen
2007-10-02 1:41 ` Timothy Shimmin
2007-10-02 7:03 ` Lachlan McIlroy
2007-10-02 8:43 ` Justin Piszcz
2007-10-03 1:49 ` Timothy Shimmin
2007-10-03 8:11 ` Justin Piszcz
2007-10-04 0:26 ` David Chinner
2007-10-04 10:59 ` Justin Piszcz
2007-10-02 9:36 ` David Chinner [this message]
2007-10-01 15:02 ` Linus Torvalds
2007-10-02 0:13 ` Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071002093629.GG995458@sgi.com \
--to=dgc@sgi.com \
--cc=lachlan@sgi.com \
--cc=sandeen@sandeen.net \
--cc=tes@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox