From: donaldd@sgi.com
To: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com
Subject: PARTIAL TAKE 971186 - Refactor xfs_mountfs
Date: Thu, 4 Oct 2007 16:26:52 +1000 (EST) [thread overview]
Message-ID: <20071004062652.557B2307DB15@linuxbuild.melbourne.sgi.com> (raw)
Refactor xfs_mountfs
Refactoring xfs_mountfs() to call sub-functions for logical
chunks can help save a bit of stack, and can make it easier to
read this long function.
The mount path is one of the longest common callchains, easily
getting to within a few bytes of the end of a 4k stack when
over lvm, quotas are enabled, and quotacheck must be done.
With this change on top of the other stack-related changes
I've sent, I can get xfs to survive a normal xfsqa run on
4k stacks over lvm.
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Date: Thu Oct 4 16:26:05 AEST 2007
Workarea: linuxbuild.melbourne.sgi.com:/home/donaldd/isms/2.6.x-xfs
Inspected by: sandeen@sandeen.net
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
Modid: xfs-linux-melb:xfs-kern:29834a
fs/xfs/xfs_mount.c - 1.415 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c.diff?r1=text&tr1=1.415&r2=text&tr2=1.414&f=h
- Refactor xfs_mountfs
reply other threads:[~2007-10-04 6:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004062652.557B2307DB15@linuxbuild.melbourne.sgi.com \
--to=donaldd@sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox