From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: review: use correct buffer flags when reading superblock
Date: Wed, 10 Oct 2007 10:34:51 +0100 [thread overview]
Message-ID: <20071010093451.GA7655@infradead.org> (raw)
In-Reply-To: <470C8F5B.90705@sgi.com>
On Wed, Oct 10, 2007 at 06:37:47PM +1000, Lachlan McIlroy wrote:
> When reading the superblock during log recovery we are not setting
> the correct buffer flags. Specifically we are not turning off flags
> we do not need such as XBF_ASYNC that is causing the synchronous
> xfs_iowait() to hang. We should also turn off XBF_WRITE and remove
> the buffer from the delay write queue just to be safe.
Where are these set up in the first time? AFAICS the buffer only written
out by xfs_unmountfs_writesb, xfs_syncsub and xfs_trans_log_buf, and all
these should only ever happen after log recovery has finished.
next prev parent reply other threads:[~2007-10-10 10:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 8:37 review: use correct buffer flags when reading superblock Lachlan McIlroy
2007-10-10 9:34 ` Christoph Hellwig [this message]
2007-10-10 11:25 ` David Chinner
2007-10-18 15:46 ` Christoph Hellwig
2007-10-19 1:32 ` Lachlan McIlroy
2007-10-19 2:14 ` David Chinner
2007-10-10 11:28 ` David Chinner
2007-10-11 2:42 ` Lachlan McIlroy
2007-10-11 3:30 ` David Chinner
2007-10-11 7:23 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071010093451.GA7655@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox