Re: review: use correct buffer flags when reading superblock

Christoph Hellwig
2007-10-10T10:04:13Z

On Wed, Oct 10, 2007 at 06:37:47PM +1000, Lachlan McIlroy wrote:
> When reading the superblock during log recovery we are not setting
> the correct buffer flags. Specifically we are not turning off flags
> we do not need such as XBF_ASYNC that is causing the synchronous
> xfs_iowait() to hang. We should also turn off XBF_WRITE and remove
> the buffer from the delay write queue just to be safe.

Where are these set up in the first time? AFAICS the buffer only written
out by xfs_unmountfs_writesb, xfs_syncsub and xfs_trans_log_buf, and all
these should only ever happen after log recovery has finished.