Re: review: use correct buffer flags when reading superblock

David Chinner
2007-10-10T11:28:39Z

On Wed, Oct 10, 2007 at 06:37:47PM +1000, Lachlan McIlroy wrote:
> When reading the superblock during log recovery we are not setting
> the correct buffer flags. Specifically we are not turning off flags
> we do not need such as XBF_ASYNC that is causing the synchronous
> xfs_iowait() to hang. We should also turn off XBF_WRITE and remove
> the buffer from the delay write queue just to be safe.

We really don't need the removal of the write flags - the XFS_bflush()
call above the xfs_getsb() call guarantees that they won't be set....

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group