From: David Chinner <dgc@sgi.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: Donald Douwsma <donaldd@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: Review: Fix dbflush panic in xfs_qm_sync
Date: Tue, 16 Oct 2007 16:07:26 +1000 [thread overview]
Message-ID: <20071016060726.GR995458@sgi.com> (raw)
In-Reply-To: <4714498A.8090902@sgi.com>
On Tue, Oct 16, 2007 at 03:18:02PM +1000, Lachlan McIlroy wrote:
> Could mp->m_quotainfo become NULL after this check but before we
> lock the list with xfs_qm_mplist_lock()? There doesn't seem to
> be any locking to protect changes to this field?
Possible - in theory. Likely - no. We do the same unlocked check in a
few places...
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-10-16 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 23:29 Review: Fix dbflush panic in xfs_qm_sync Donald Douwsma
2007-10-16 5:18 ` Lachlan McIlroy
2007-10-16 6:07 ` David Chinner [this message]
2007-10-17 1:54 ` Donald Douwsma
2007-10-18 16:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071016060726.GR995458@sgi.com \
--to=dgc@sgi.com \
--cc=donaldd@sgi.com \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox