From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>, xfs-dev <xfs-dev@sgi.com>
Subject: Re: [REVIEW] Refactor xfs_repair's process_dinode_int
Date: Wed, 21 Nov 2007 15:05:26 +0000 [thread overview]
Message-ID: <20071121150526.GA8454@infradead.org> (raw)
In-Reply-To: <op.t1tl53ac3jf8g2@pc-bnaujok.melbourne.sgi.com>
On Thu, Nov 15, 2007 at 05:40:41PM +1100, Barry Naujok wrote:
> Implementing casefold-table checking in xfs_repair, I have to
> touch process_dinode_int. It's a horrendous function. The attached
> patch hopefully makes it much clearer what it does and removes a
> lot of duplicate code when bad inodes are found. There are some
> obscure bug fixes too (eg. two places where the inode's di_mode is
> updated, but not marked dirty - libxfs would have tossed it).
>
> The refactoring involved removing unused variables, working out
> what various variables actually did and use them appropriately
> and break blocks of functionality into separate functions.
This looks very good f4rom a quick glance over it. I can't claim
I've verified that it still does the same thing, though.
next prev parent reply other threads:[~2007-11-21 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 6:40 [REVIEW] Refactor xfs_repair's process_dinode_int Barry Naujok
2007-11-21 15:05 ` Christoph Hellwig [this message]
2008-01-16 1:03 ` Michael Nishimoto
[not found] <4782B72D.8070208@agami.com>
[not found] ` <47833C0F.6070206@agami.com>
[not found] ` <op.t4m0r1an3jf8g2@pc-bnaujok.melbourne.sgi.com>
[not found] ` <478D1899.9080201@agami.com>
2008-01-16 0:51 ` Barry Naujok
2008-01-16 2:33 ` Barry Naujok
2008-01-16 3:10 ` Timothy Shimmin
2008-01-16 4:59 ` David Chinner
2008-01-16 6:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071121150526.GA8454@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox