From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: David Chinner <dgc@sgi.com>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH,RFC] Factor some btree code....
Date: Thu, 22 Nov 2007 08:42:08 +1100 [thread overview]
Message-ID: <20071121214208.GE114266761@sgi.com> (raw)
In-Reply-To: <20071121152006.GD8454@infradead.org>
On Wed, Nov 21, 2007 at 03:20:06PM +0000, Christoph Hellwig wrote:
>
> I like this. But I think a single set of xfs_btree_ops would be a lot
> more readable. Also I'm not sure we actually need all these ops, e.g.
> instead of .buf_to_block we could always just call XFS_BUF_PTR directly.
I've already converted it to a single ops structure and cut out quite
a few ops that could be generic (sibling ops, checking ops, numrecs
ops, etc). I opted for moving them all over initially and now I'm culling
the common stuff. .buf_to_block is another one that can go, .buf_to_ptr
can be done generically, too....
I'm still flshing bugs out, so i haven't posted an update. When I get
it to pass xfsqa I'll send out an updated patchset.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2007-11-21 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 9:18 [PATCH,RFC] Factor some btree code David Chinner
2007-11-21 15:20 ` Christoph Hellwig
2007-11-21 21:42 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071121214208.GE114266761@sgi.com \
--to=dgc@sgi.com \
--cc=hch@infradead.org \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox