From: David Chinner <dgc@sgi.com>
To: Matt Mackall <mpm@selenic.com>
Cc: David Chinner <dgc@sgi.com>, Andi Kleen <andi@firstfloor.org>,
xfs-oss <xfs@oss.sgi.com>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/9]: Reduce Log I/O latency
Date: Fri, 23 Nov 2007 09:29:09 +1100 [thread overview]
Message-ID: <20071122222909.GY114266761@sgi.com> (raw)
In-Reply-To: <20071122181029.GR19691@waste.org>
On Thu, Nov 22, 2007 at 12:10:29PM -0600, Matt Mackall wrote:
> On Thu, Nov 22, 2007 at 09:31:59PM +1100, David Chinner wrote:
> [...]
> > > In other words, I/O priority is per-spindle and not per-filesystem and
> > > thus this change has consequences that leak outside the filesystem in
> > > question. That's bad.
> >
> > This has nothing to do with this patch - it's a problem with sharing
> > a single resource in a RT system between two non-deterministic
> > constructs. e.g. I can put two ext3 filesystems on the one spindle,
> > run two completely independent RT workloads on the different
> > filesystems and have one workload DOS the other due to differences
> > in priority at the spindle.
>
> Sure. And it's up to the RT system designer not to do something stupid
> like that. The problem is that your patch potentially promotes a
> non-RT I/O activity to an RT one without regard to the rest of the
> system.
So this:
http://marc.info/?l=linux-kernel&m=119247074517414&w=2
shouldn't be allowed, either? (rt kjournald for ext3)
> Perfectly understood. And that's fine. A system designer is allowed to
> shoot himself in the foot.
Ok. I'll point anyone that complains at you, Matt ;)
> I don't think there's any fundamental reason the I/O subsystem or
> filesystems can't be taught to handle priority inversion, which is
> much more acceptable and general fix.
See my reply to Andi.
> If I've got XFS on filesystems A and B on the same spindle (or volume
> group?) and my real RT I/O takes place only on B, then I want log
> flushing to happen in RT on B. But -never on A-. If I can do this with
> a tunable, I'm perfectly happy.
No, not another mount option. I'm just going to drop this one for
now...
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-11-22 22:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071122003339.GH114266761__34694.2978365861$1195691722$gmane$org@sgi.com>
2007-11-22 0:49 ` [PATCH 2/9]: Reduce Log I/O latency Andi Kleen
2007-11-22 1:12 ` David Chinner
2007-11-22 2:57 ` Matt Mackall
2007-11-22 3:41 ` David Chinner
2007-11-22 7:25 ` Matt Mackall
2007-11-22 10:31 ` David Chinner
2007-11-22 18:10 ` Matt Mackall
2007-11-22 22:29 ` David Chinner [this message]
2007-11-22 23:09 ` David Chinner
2007-11-23 0:21 ` Matt Mackall
2007-11-23 0:20 ` Matt Mackall
2007-11-22 3:28 ` Stewart Smith
2007-11-22 12:06 ` Andi Kleen
2007-11-22 13:15 ` David Chinner
2007-11-23 2:53 ` Andi Kleen
2007-11-23 4:03 ` David Chinner
2007-11-23 12:01 ` Andi Kleen
2007-11-24 18:43 ` Matt Mackall
2007-11-22 0:33 David Chinner
2007-11-26 2:11 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071122222909.GY114266761@sgi.com \
--to=dgc@sgi.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox