From: David Chinner <dgc@sgi.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: David Chinner <dgc@sgi.com>, xfs-oss <xfs@oss.sgi.com>,
xfs-dev <xfs-dev@sgi.com>
Subject: Re: [PATCH 2/2] Debug - don't exhaustively check the AIL on every operation
Date: Fri, 23 Nov 2007 12:24:25 +1100 [thread overview]
Message-ID: <20071123012425.GA114266761@sgi.com> (raw)
In-Reply-To: <47462222.9060501@sgi.com>
On Fri, Nov 23, 2007 at 11:43:14AM +1100, Lachlan McIlroy wrote:
> Looks good Dave.
>
> There's lots of debug code bound by XFS_TRANS_DEBUG - should we be
> enabling this in our QA?
No, they are more for validation when you are hacking on the
transaction code. The current debug code should detect most
problems runtime problems, but if you change the way anything in the
logging works you'll be wanting to test your changes with that set
(e.g. when we do the transaction rollback stuff).
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2007-11-23 1:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 0:50 [PATCH 2/2] Debug - don't exhaustively check the AIL on every operation David Chinner
2007-11-23 0:43 ` Lachlan McIlroy
2007-11-23 1:24 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123012425.GA114266761@sgi.com \
--to=dgc@sgi.com \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox