From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/9] Don't block pdflush when flushing inodes
Date: Fri, 23 Nov 2007 17:50:53 +0000 [thread overview]
Message-ID: <20071123175053.GA12649@infradead.org> (raw)
In-Reply-To: <20071122003817.GK114266761@sgi.com>
> +++ 2.6.x-xfs-new/fs/xfs/xfs_inode.c 2007-11-22 10:33:51.037704348 +1100
> @@ -183,12 +183,20 @@ xfs_imap_to_bp(
> int ni;
> xfs_buf_t *bp;
>
> + if (buf_flags == 0)
> + buf_flags = XFS_BUF_LOCK;
There's just two caller and they never pass 0, so this is not needed.
> + error = xfs_itobp_flags(mp, NULL, ip, &dip, &bp, 0, 0,
> + (noblock) ? XFS_BUF_TRYLOCK : XFS_BUF_LOCK);
no need for the braces around noblock.
> +int xfs_itobp_flags(struct xfs_mount *, struct xfs_trans *,
> xfs_inode_t *, struct xfs_dinode **, struct xfs_buf **,
> - xfs_daddr_t, uint);
> + xfs_daddr_t, uint, uint);
> +#define xfs_itobp(mp, tp, ip, dipp, bpp, bno, iflags) \
> + xfs_itobp_flags(mp, tp, ip, dipp, bpp, bno, iflags, XFS_BUF_LOCK)
I'd say just convert xfs_itobp and all it's user to take the additional
argument.
prev parent reply other threads:[~2007-11-23 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 0:38 [PATCH 5/9] Don't block pdflush when flushing inodes David Chinner
2007-11-23 17:50 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123175053.GA12649@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox