From: lachlan@sgi.com (Lachlan McIlroy)
To: sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com
Subject: TAKE 964002 - Don't wait for pending I/Os when purging blocks beyond eof.
Date: Mon, 10 Dec 2007 16:59:55 +1100 (EST) [thread overview]
Message-ID: <20071210055955.0F96358C4C34@chook.melbourne.sgi.com> (raw)
Don't wait for pending I/Os when purging blocks beyond eof.
On last close of a file we purge blocks beyond eof. The same
code is used when we truncate the file size down. In this case
we need to wait for any pending I/Os for dirty pages beyond the
new eof. For the last close case we are not changing the file
size and therefore do not need to wait for any I/Os to complete.
This fixes a performance bottleneck where writes into the page
cache and cache flushes can become mutually exclusive.
Date: Mon Dec 10 16:59:09 AEDT 2007
Workarea: redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-vniowait
Inspected by: pleckie
Author: lachlan
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
Modid: xfs-linux-melb:xfs-kern:30220a
fs/xfs/xfs_inode.c - 1.489 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_inode.c.diff?r1=text&tr1=1.489&r2=text&tr2=1.488&f=h
- Don't wait for pending I/Os when purging blocks beyond eof.
next reply other threads:[~2007-12-10 21:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 5:59 Lachlan McIlroy [this message]
2007-12-11 8:11 ` TAKE 964002 - Don't wait for pending I/Os when purging blocks beyond eof Christoph Hellwig
2007-12-11 23:25 ` David Chinner
2007-12-12 5:13 ` Christoph Hellwig
2007-12-11 16:52 ` Bhagi rathi
2007-12-12 4:04 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071210055955.0F96358C4C34@chook.melbourne.sgi.com \
--to=lachlan@sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox