public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Vlad Apostolov <vapo@sgi.com>,
	Christoph Hellwig <hch@infradead.org>,
	Mark Goodwin <markgw@sgi.com>, xfs-dev <xfs-dev@sgi.com>,
	xfs-oss <xfs@oss.sgi.com>
Subject: Re: DMAPI problem with the new filldir implementation
Date: Mon, 10 Dec 2007 20:48:20 +0000	[thread overview]
Message-ID: <20071210204820.GA27456@infradead.org> (raw)
In-Reply-To: <20071207014940.GS115527101@sgi.com>


Looks good to me.  Might be worth to add a test that does a readdir
with a small buffer where only "." fits so we don't regress that special
case.

      parent reply	other threads:[~2007-12-10 22:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <475879DB.40705@sgi.com>
2007-12-07  0:29 ` DMAPI problem with the new filldir implementation David Chinner
2007-12-07  1:49   ` David Chinner
2007-12-10  7:04     ` [review please] " David Chinner
2007-12-10 20:48     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071210204820.GA27456@infradead.org \
    --to=hch@infradead.org \
    --cc=dgc@sgi.com \
    --cc=markgw@sgi.com \
    --cc=vapo@sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox