public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: lachlan@sgi.com, Donald Douwsma <donaldd@sgi.com>,
	xfs-oss <xfs@oss.sgi.com>
Subject: Re: [review] Remove the xfs refcache
Date: Mon, 17 Dec 2007 07:15:46 +0000	[thread overview]
Message-ID: <20071217071546.GB11462@infradead.org> (raw)
In-Reply-To: <47660DB7.5000104@sandeen.net>

On Sun, Dec 16, 2007 at 11:48:39PM -0600, Eric Sandeen wrote:
> Lachlan McIlroy wrote:
> > Hey hold on there buddy!  We may need to reactivate this code to fix some
> > performance issues.  I've acttually got this code working and proven that
> > it is one way to fix some of the NAS/NFS issues we have.
> > 
> > The little comment that reads "reference cache not needed for NFS in 2.6"
> > is wrong - we do need it or something like it.
> 
> So, the whole reason this was not built for 2.6 was that ostensibly the
> 2.6 kernel already did this sort of caching for nfs.  But, last time I
> looked I didn't see anything obvious.  Anybody know? :)

nfsd in 2.6 keeps the inodes around, which is 90% of what the open files
cache did.  Now what it also does is to not release preallocations
everytime but keep them while the inode is in the refcache.  For that
we'll need some additional support, and the best would be an open files
cache like the one Greg has been hacking on for quite a while.

  reply	other threads:[~2007-12-17  7:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17  3:26 [review] Remove the xfs refcache Donald Douwsma
2007-12-17  4:00 ` Lachlan McIlroy
2007-12-17  4:12   ` Donald Douwsma
2007-12-17  5:48   ` Eric Sandeen
2007-12-17  7:15     ` Christoph Hellwig [this message]
2007-12-17  7:14   ` Christoph Hellwig
2007-12-17  7:39     ` Greg Banks
2007-12-18  4:12     ` Lachlan McIlroy
2007-12-18  7:44       ` David Chinner
2007-12-19  3:43         ` David Chinner
2008-02-07  8:35 ` Christoph Hellwig
2008-02-11 13:00   ` Donald Douwsma
2008-02-11 16:32     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071217071546.GB11462@infradead.org \
    --to=hch@infradead.org \
    --cc=donaldd@sgi.com \
    --cc=lachlan@sgi.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox