From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Timothy Shimmin <tes@sgi.com>, Barry Naujok <bnaujok@sgi.com>,
Chandan Talukdar <chandan@agami.com>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [REVIEW] Refactor xfs_repair's process_dinode_int
Date: Wed, 16 Jan 2008 06:32:35 +0000 [thread overview]
Message-ID: <20080116063234.GA21317@infradead.org> (raw)
In-Reply-To: <20080116045943.GU155407@sgi.com>
On Wed, Jan 16, 2008 at 03:59:43PM +1100, David Chinner wrote:
> As a result the kernel does not have endian types for single
> byte variables (ie. there's __be16, __be32, __be64 but not __be8),
> nor are there cpu_to_be8 or be8_to_cpu conversion functions.
> Hence the lack of them in the XFS code ;)
>
> > I guess you might consider that you are letting people know
> > that we need to endian convert this value in general and
> > that if we change the code in the future it might be needed...
>
> Well, that should be obvious when changing the structure
> that has lots of __beX types in already....
Actually enabling sparse checking for endianess annotations is still on
my todo list. I started this project a while ago but failed when the
cgcc wrapper had some problems interacting with libtool. I'll see how
to get that resolved.
next prev parent reply other threads:[~2008-01-16 6:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4782B72D.8070208@agami.com>
[not found] ` <47833C0F.6070206@agami.com>
[not found] ` <op.t4m0r1an3jf8g2@pc-bnaujok.melbourne.sgi.com>
[not found] ` <478D1899.9080201@agami.com>
2008-01-16 0:51 ` [REVIEW] Refactor xfs_repair's process_dinode_int Barry Naujok
2008-01-16 2:33 ` Barry Naujok
2008-01-16 3:10 ` Timothy Shimmin
2008-01-16 4:59 ` David Chinner
2008-01-16 6:32 ` Christoph Hellwig [this message]
2007-11-15 6:40 Barry Naujok
2007-11-21 15:05 ` Christoph Hellwig
2008-01-16 1:03 ` Michael Nishimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080116063234.GA21317@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@sgi.com \
--cc=chandan@agami.com \
--cc=dgc@sgi.com \
--cc=tes@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox