public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>, xfs-dev <xfs-dev@sgi.com>
Subject: Re: [REVIEW 1/2] Case insensitive support for XFS - kernel patch
Date: Wed, 23 Jan 2008 06:55:22 +0000	[thread overview]
Message-ID: <20080123065522.GA11132@infradead.org> (raw)
In-Reply-To: <op.t49g2olx3jf8g2@pc-bnaujok.melbourne.sgi.com>

I'm currently sick in my bed, so just a very quick glance over the
patch and a few comments:

 - no need to export the new inode ops, they're not used by the quota
   or dmapi methods.
 - any chance you could rebase this ontop of my various vnode removals,
   this should make some things a little cleaner.
 - there's a lot of hair dcache internals in here, so please run this
   patch past linux-fsdevel@vger.kernel.org to get some broader review.

  reply	other threads:[~2008-01-23  6:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18  4:43 [REVIEW 1/2] Case insensitive support for XFS - kernel patch Barry Naujok
2008-01-19  5:22 ` Eric Sandeen
2008-01-21  3:53   ` Barry Naujok
2008-01-23  6:55     ` Christoph Hellwig [this message]
2008-01-19  5:30 ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080123065522.GA11132@infradead.org \
    --to=hch@infradead.org \
    --cc=bnaujok@sgi.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox