From: Christoph Hellwig <hch@infradead.org>
To: Matthias Schniedermeyer <ms@citd.de>
Cc: xfs@oss.sgi.com
Subject: Re: XFS doesn't correctly account for IO-Wait for directory reading
Date: Wed, 23 Jan 2008 12:17:41 +0000 [thread overview]
Message-ID: <20080123121741.GA24405@infradead.org> (raw)
In-Reply-To: <20080123110027.GA10366@citd.de>
Try this one-liner patch which should give you much better I/O wait
reporting. There's some more I/O waits hidden in the log code, but to
fix this we'd need to dig into the sv_t abstraction. Given that it only
has four users left I'm probably going to simply remove it and fix the
I/O wait accounting while I'm at it.
--- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_buf.c 2008-01-23 13:08:48.000000000 +0100
+++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_buf.c 2008-01-23 13:08:54.000000000 +0100
@@ -976,7 +976,7 @@ xfs_buf_wait_unpin(
break;
if (atomic_read(&bp->b_io_remaining))
blk_run_address_space(bp->b_target->bt_mapping);
- schedule();
+ io_schedule();
}
remove_wait_queue(&bp->b_waiters, &wait);
set_current_state(TASK_RUNNING);
next prev parent reply other threads:[~2008-01-23 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 11:00 XFS doesn't correctly account for IO-Wait for directory reading Matthias Schniedermeyer
2008-01-23 12:17 ` Christoph Hellwig [this message]
2008-01-23 14:24 ` Matthias Schniedermeyer
2008-01-24 0:31 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080123121741.GA24405@infradead.org \
--to=hch@infradead.org \
--cc=ms@citd.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox