Re: [PATCH, mainline-only] remove dmapi cruft in xfs_file.c

Christoph Hellwig
2008-02-28T23:30:36Z

On Thu, Feb 28, 2008 at 04:40:09PM -0600, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > The dmapi cruft in xfs_file.c is totally out of date in mainline vs
> > CVS, and at this point just removing this code which can't be used on
> > mainline at all seems to be the best option to keep it maintainable.
>
> When doing this should probably whack the:
>
> #ifdef HAVE_FOP_OPEN_EXEC
> .open_exec = xfs_file_open_exec,
> #endif
>
> from xfs_file_operations, too?

Yes, but no urgeny for now as we've missed the .25 window anyway.