From: David Chinner <dgc@sgi.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com
Subject: Re: PARTIAL TAKE 971186 - Fix regression due to refcache removal
Date: Thu, 14 Feb 2008 13:59:36 +1100 [thread overview]
Message-ID: <20080214025935.GJ155259@sgi.com> (raw)
In-Reply-To: <20080214011850.8F03858C4C11@chook.melbourne.sgi.com>
On Thu, Feb 14, 2008 at 12:18:50PM +1100, Lachlan McIlroy wrote:
> Fix regression due to refcache removal
Can we please use more descriptive check-in messages?
Remember, the description is what ends up in the git commit log and
so needs to include a summary of the problem and the fix that was
made. That way the it's easy see what changes were made when read
the git log without needed to look at diffs.
IOWs, the description should read:
"Fix a regression due to the refcache removal.
Some code in xfs_rwunlock() was accidentally removed
when removing the refcache. This results in inodes not
being properly unlocked and causes system hangs. Fixed
by reinstating the missing code."
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2008-02-14 2:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 1:18 PARTIAL TAKE 971186 - Fix regression due to refcache removal Lachlan McIlroy
2008-02-14 2:59 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214025935.GJ155259@sgi.com \
--to=dgc@sgi.com \
--cc=lachlan@sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox