* PARTIAL TAKE 971186 - Fix regression due to refcache removal
@ 2008-02-14 1:18 Lachlan McIlroy
2008-02-14 2:59 ` David Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Lachlan McIlroy @ 2008-02-14 1:18 UTC (permalink / raw)
To: sgi.bugs.xfs, xfs
Fix regression due to refcache removal
Date: Thu Feb 14 12:17:28 AEDT 2008
Workarea: redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-test
Inspected by: donaldd
Author: lachlan
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
Modid: xfs-linux-melb:xfs-kern:30490a
fs/xfs/xfs_vnodeops.c - 1.733 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vnodeops.c.diff?r1=text&tr1=1.733&r2=text&tr2=1.732&f=h
- Fix regression due to refcache removal
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PARTIAL TAKE 971186 - Fix regression due to refcache removal
2008-02-14 1:18 PARTIAL TAKE 971186 - Fix regression due to refcache removal Lachlan McIlroy
@ 2008-02-14 2:59 ` David Chinner
0 siblings, 0 replies; 2+ messages in thread
From: David Chinner @ 2008-02-14 2:59 UTC (permalink / raw)
To: Lachlan McIlroy; +Cc: sgi.bugs.xfs, xfs
On Thu, Feb 14, 2008 at 12:18:50PM +1100, Lachlan McIlroy wrote:
> Fix regression due to refcache removal
Can we please use more descriptive check-in messages?
Remember, the description is what ends up in the git commit log and
so needs to include a summary of the problem and the fix that was
made. That way the it's easy see what changes were made when read
the git log without needed to look at diffs.
IOWs, the description should read:
"Fix a regression due to the refcache removal.
Some code in xfs_rwunlock() was accidentally removed
when removing the refcache. This results in inodes not
being properly unlocked and causes system hangs. Fixed
by reinstating the missing code."
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-14 2:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-14 1:18 PARTIAL TAKE 971186 - Fix regression due to refcache removal Lachlan McIlroy
2008-02-14 2:59 ` David Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox