From: David Chinner <dgc@sgi.com>
To: Mark Goodwin <markgw@sgi.com>
Cc: David Chinner <dgc@sgi.com>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [patch] Don't change ctime in truncate is size does not change
Date: Tue, 19 Feb 2008 12:55:20 +1100 [thread overview]
Message-ID: <20080219015520.GA155407@sgi.com> (raw)
In-Reply-To: <47BA16CC.7040700@sgi.com>
On Tue, Feb 19, 2008 at 10:37:48AM +1100, Mark Goodwin wrote:
> Did we ever discover what was behind the comment:
> "Have to do this even if the file's size doesn't change"
It was put there when the patch was checked in - I can only
assume that it was done this way because the old test script
that was being run didn't discriminate between the truncate
and truncate differences.
Basically, both the code and the comment are wrong and needed
to be fixed....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2008-02-19 1:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 23:32 [patch] Don't change ctime in truncate is size does not change David Chinner
2008-02-18 23:37 ` Mark Goodwin
2008-02-19 1:55 ` David Chinner [this message]
2008-02-20 23:26 ` Christoph Hellwig
2008-02-21 22:50 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219015520.GA155407@sgi.com \
--to=dgc@sgi.com \
--cc=markgw@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox